Fix Content-Disposition filename encoding #6473
Conversation
There was a problem hiding this comment.
This is great. Thank you for your work!
A bit more context for readers - RFC declares that:
Inside the value part, characters not contained in attr-char are
encoded into an octet sequence using the specified character
encoding. That octet sequence is then percent-encoded as specified
in Section 2.1 of [RFC3986].
The whole PR is excellent a few minor suggestions:
core/src/main/scala/org/http4s/headers/Content-Disposition.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/http4s/headers/Content-Disposition.scala
Outdated
Show resolved
Hide resolved
tests/src/test/scala/org/http4s/parser/ContentDispositionHeaderSuite.scala
Show resolved
Hide resolved
Co-authored-by: Daniel Esik <e.danicheg@yandex.ru>
|
@danicheg what about fix it in 0.23? I can submit another PR. WDYT? |
|
@leoniv thanks! No need to worry about that, after we merge this PR we will merge the series/0.22 branch into series/0.23 :) |
|
Thanks! 0.22 is officially EOL, but if it bothered you enough to fix there, it's easy enough for us to do a courtesy release there. I'll get that started. |
|
Thanks, we a little bit behind the progress :) |
|
v0.22.14 is releasing from CI now with this. I'll be asleep before it finishes. 😄 |
Hi! It was easy to fix it, instead of submitting an issue. I faced the problem at 0.22 I suspect it's present at 0.23 too.