Remove scalafix migrations, plugin cleanup #6460
Conversation
|
In theory we could remove this dep, since we now get it from sbt-http4s-org via sbt-typelevel-scalafix. |
|
Let's do that instead. |
scalafix/project/plugins.sbt
Outdated
| @@ -1,5 +1,5 @@ | |||
| resolvers += Resolver.sonatypeRepo("releases") | |||
|
|
|||
| addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.10.0") | |||
| addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.10.1") | |||
There was a problem hiding this comment.
Oh, woops, I take that back. I guess we need it for this nested project, unless we replace this with sbt-http4s-org too?
There was a problem hiding this comment.
Ok, I have a long-strategy plan.
Every project I've seen that does scalafix uses the 4 module rules/input/output/tests layout. This includes typelevel-scalafix, and both the http4s internal scalafixes, and the http4s external scalafixes that live in their own sbt project under the scalafix/ directory (which I now suspect is unnecessary).
@DavidGregory084 was able to extract out this project-setup logic nicely in typelevel-scalafix. We should lift that into sbt-typelevel-scalafix plugin, then we can reuse it everywhere.
That will make it easy for us to merge this independent scalafix/ project into the main http4s build, and then it doesn't need its own plugins.
|
Investigating further, our external scalafix aren't even tested against 0.23+. So we are burning CI to test them. Line 2 in 5666d4e Many of the rules are blaze related anyway, which is also no longer here. Granted I fix the documentation to show how to run them from the 0.22 branch, can we just drop them from 0.23+? |
|
Yeah, sounds good to me. |
Updates
from 0.10.0 to 0.10.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Files still referring to the old version number
The following files still refer to the old version number (0.10.0).
You might want to review and update them manually.
Ignore future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:labels: library-update, early-semver-minor, semver-spec-patch, old-version-remains, commit-count:1