Skip to content

Backport of Router#define test #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2022
Merged

Backport of Router#define test #6451

merged 1 commit into from
Jun 5, 2022

Conversation

danicheg
Copy link
Member

@danicheg danicheg commented Jun 5, 2022

As we agreed, this is a backport of the Router's empty path case test.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:server labels Jun 5, 2022
armanbilge
armanbilge approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@armanbilge armanbilge merged commit 948c20d into http4s:series/0.23 Jun 5, 2022
@rossabaker rossabaker added the behind-the-scenes Appreciated, but not user-facing label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
behind-the-scenes Appreciated, but not user-facing module:server series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danicheg @armanbilge @rossabaker