Ember-Core - H2Client - Rewrite without alternative. #6422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
approved these changes
May 28, 2022
danicheg
approved these changes
May 28, 2022
| @@ -361,26 +361,21 @@ private[ember] object H2Client { | |||
| } yield (http1Client: TinyClient[F]) => { (req: Request[F]) => | |||
| val key = H2Client.RequestKey.fromRequest(req) | |||
| val priorKnowledge = req.attributes.lookup(H2Keys.Http2PriorKnowledge).isDefined | |||
| val h2Prior = Alternative[Option].guard(priorKnowledge).as(Http2) | |||
| for { | |||
| socketType <- Resource.eval( | |||
There was a problem hiding this comment.
Whoa, it seems socketType has been computing regardless of the guard's result. This refactoring could also bring saving a few processor ticks. 👏🏻
In this code, the use of Alternative[Option] can be replaced with an if-then-else statement. Furthermore, we can replace the for-comprehension with a simple flatMap and less inlining.
0d9fa5d to
5e5357f
Compare
diesalbla
commented
May 28, 2022
| ).handleErrorWith[org.http4s.Response[F], Throwable] { | ||
| case InvalidSocketType() | MissingHost() | MissingPort() => | ||
| Resource.eval(socketMap.update(s => s + (key -> Http1))) >> | ||
| http1Client(req) |
There was a problem hiding this comment.
@armanbilge Thanks for fixing this, just pushed a full change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this code, the use of
Alternative[Option]can be replaced with an if-then-else statement. Furthermore, we can replace the for-comprehension with a simple flatMap and less inlining.Note: most changes are whitespace.