Ember-Client: no Alternative #6426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
reviewed
May 29, 2022
| }, | ||
| ) | ||
| ) | ||
| optH2 <- (if (enableHttp2) tlsContextOptWithDefault else None).traverse { context => |
There was a problem hiding this comment.
Is it the case when Applicative#when fits well?
There was a problem hiding this comment.
No, because this yields an Option, and the when is for F[Unit]. In any case, that is still less straightforward than if-then-else.
The use of Alternative type-class can be replaced with basic Scala construct.
e91c770 to
f89432d
Compare
armanbilge
approved these changes
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
>>and guard from Alternative type-class can be replaced with basic if-then-else Scala construct.