Skip to content

Use GenTemporal for proceeding with timeouts #6391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2022
Merged

Use GenTemporal for proceeding with timeouts #6391

merged 2 commits into from
May 19, 2022

Conversation

danicheg
Copy link
Member

Refactors the direct races in favor of GenTemporal algebra.

@danicheg
Copy link
Member Author

These errors in CI are getting annoying.

Run sbt 'project rootJS' '++3.1.2' 'project /' githubWorkflowCheck
[info] [launcher] getting org.scala-sbt sbt 1.6.2  (this may take some time)...
[info] [launcher] getting Scala 2.[12](https://github.com/http4s/http4s/runs/6501300446?check_suite_focus=true#step:10:13).15 (for sbt)...
[info] welcome to sbt 1.6.2 (Temurin Java 1.8.0_332)
[info] loading settings for project http4s-build from build.sbt,plugins.sbt ...
[info] loading project definition from /home/runner/work/http4s/http4s/project
[warn] 
[warn] 	Note: Some unresolved dependencies have extra attributes.  Check that these dependencies exist with the requested attributes.
[warn] 		org.portable-scala:sbt-crossproject:1.2.0 (scalaVersion=2.12, sbtVersion=1.0)
[warn] 
[warn] 	Note: Unresolved dependencies path:
[error] sbt.librarymanagement.ResolveException: Error downloading org.portable-scala:sbt-crossproject;info.versionScheme=semver-spec;sbtVersion=1.0;scalaVersion=2.12:1.2.0

@armanbilge
Copy link
Member

Yep they are 😕 idk what's causing this network issues recently.

Also I have some ideas to improve caching in sbt-typelevel, so that we don't need to download so often.

@danicheg danicheg merged commit 74b0c86 into http4s:series/0.23 May 19, 2022
@danicheg danicheg deleted the http2-node-stage-timeout branch May 19, 2022 09:23
@rossabaker rossabaker added the behind-the-scenes Appreciated, but not user-facing label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
behind-the-scenes Appreciated, but not user-facing module:blaze-server module:server series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danicheg @armanbilge @rossabaker