Add AttemptCountKey - Allow other middlewares access to what retry count we are on. #6367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recommend hiding whitespace as it reformatted a bunch more than what I changed. |
armanbilge
reviewed
May 6, 2022
client/shared/src/main/scala/org/http4s/client/middleware/Retry.scala
Outdated
Show resolved
Hide resolved
armanbilge
approved these changes
May 6, 2022
isomarcte
approved these changes
May 6, 2022
danicheg
reviewed
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow other middlewares the ability to see retry count on either the request or response depending on where the middlewares are applied.