Skip to content

httpRoutes and httpApp shortcuts for Timeout middleware #6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2022
Merged

httpRoutes and httpApp shortcuts for Timeout middleware #6366

merged 2 commits into from
May 16, 2022

Conversation

voidcontext
Copy link
Contributor

This PR implements the httpApp and httpRoutes shortcuts of the Timeout middleware. See #2402.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:server labels May 6, 2022
@voidcontext
Copy link
Contributor Author

It seems the failing test in `org.http4s.blaze.client.ClientTimeoutSuite is flaky, as it's in a different module. Can someone please rerun the CI jobs?

rossabaker
rossabaker approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@rossabaker rossabaker merged commit 3648c63 into http4s:series/0.23 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
module:server series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voidcontext @rossabaker