Skip to content

Delete servlet and jetty-server srcs #6354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

Delete servlet and jetty-server srcs #6354

merged 1 commit into from
May 2, 2022

Conversation

armanbilge
Copy link
Member

I'm confused why they weren't deleted as part of #6240. These sources aren't compiled as part of any project.

@armanbilge armanbilge added the behind-the-scenes Appreciated, but not user-facing label May 2, 2022
rossabaker
rossabaker approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the scope of that ticket expanded and I just missed it.

@rossabaker rossabaker merged commit adf0225 into http4s:series/0.23 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
behind-the-scenes Appreciated, but not user-facing module:jetty-server module:servlet series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @rossabaker