Skip to content

Update scala3-library, ... to 3.1.2 in series/0.23 #6291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 5, 2022
Merged

Update scala3-library, ... to 3.1.2 in series/0.23 #6291

merged 6 commits into from
May 5, 2022

Conversation

scala-steward
Copy link
Contributor

Updates

from 3.1.1 to 3.1.2.
GitHub Release Notes - Version Diff - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (3.1.1).
You might want to review and update them manually.

core/shared/src/main/scala/org/http4s/headers/Content-Type.scala
docs/changelog.md
docs/docs/static.md
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:n:2

@mergify mergify bot added series/0.23 PRs targeting 0.23.x dependencies Dependency updates labels Apr 12, 2022
@danicheg
Copy link
Member

This is blocked by lightbend-labs/mima#693

@armanbilge
Copy link
Member

@danicheg did this fix itself somehow?

@armanbilge
Copy link
Member

I'm going to re-run CI just to check if it's non-deterministic somehow.

armanbilge
armanbilge approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what changed, but seems stable ✅

I did confirm that we are still running MiMa 😅

@danicheg
Copy link
Member

danicheg commented May 5, 2022

This is a miracle or something 😆 If I'm not wrong, lightbend-labs/mima#696 wasn't released, so I also don't get why it's working..

@armanbilge
Copy link
Member

Oh, I know what changed. All the previous issues were signatures related to scodec-bits. But we updated scodec-bits in #6330, and scodec-bits itself updated to Scala 3.1 in that release.

[error] ember-core: Failed binary compatibility check against org.http4s:http4s-ember-core_3:0.23.0 (e:info.versionScheme=early-semver)! Found 8 potential problems (filtered 114)
[error]  * static method 
[error] ()scodec.bits.ByteVector in class org.http4s.ember.core.Shared has a different generic signature in current version, where it is ()Lscodec/bits/ByteVector; rather than <missing>. See https://github.com/lightbend/mima#incompatiblesignatureproblem
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("org.http4s.ember.core.Shared.
[error] ")
()scodec.bits.ByteVector in class org.http4s.ember.core.Shared has a different generic signature in current version, where it is ()Lscodec/bits/ByteVector; rather than <missing>. See https://github.com/lightbend/mima#incompatiblesignatureproblem
")
[error]  * static method 
[error] ()scodec.bits.ByteVector in class org.http4s.ember.core.Shared has a different generic signature in current version, where it is ()Lscodec/bits/ByteVector; rather than <missing>. See https://github.com/lightbend/mima#incompatiblesignatureproblem
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("org.http4s.ember.core.Shared.
[error] ")
[error]  * static method 
[error] 
[error] ()scodec.bits.ByteVector in class org.http4s.ember.core.Shared has a different generic signature in current version, where it is ()Lscodec/bits/ByteVector; rather than <missing>. See https://github.com/lightbend/mima#incompatiblesignatureproblem
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("org.http4s.ember.core.Shared.
[error] 
[error] ")
[error]  * method 
[error] ()scodec.bits.ByteVector in object org.http4s.ember.core.Shared has a different generic signature in current version, where it is ()Lscodec/bits/ByteVector; rather than <missing>. See https://github.com/lightbend/mima#incompatiblesignatureproblem
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("org.http4s.ember.core.Shared.
[error] ")
()scodec.bits.ByteVector in object org.http4s.ember.core.Shared has a different generic signature in current version, where it is ()Lscodec/bits/ByteVector; rather than <missing>. See https://github.com/lightbend/mima#incompatiblesignatureproblem
")
[error]  * method 
[error] ()scodec.bits.ByteVector in object org.http4s.ember.core.Shared has a different generic signature in current version, where it is ()Lscodec/bits/ByteVector; rather than <missing>. See https://github.com/lightbend/mima#incompatiblesignatureproblem
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("org.http4s.ember.core.Shared.
[error] ")
[error]  * method 
[error] 
[error] ()scodec.bits.ByteVector in object org.http4s.ember.core.Shared has a different generic signature in current version, where it is ()Lscodec/bits/ByteVector; rather than <missing>. See https://github.com/lightbend/mima#incompatiblesignatureproblem
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("org.http4s.ember.core.Shared.
[error] 
[error] ")

@armanbilge
Copy link
Member

No 😕 I tried rolling back scodec-bits, but still no issues. I'm still able to replicate the issues on 7b87722 so it must be some other change 🤔

@armanbilge
Copy link
Member

No no I was wrong ... actually it was the MiMa update that fixed this. 7b87722 was still using MiMa 1.0 via sbt-http4s-org 0.13.1, this problem must have been fixed in MiMa 1.1 via sbt-http4s-org 0.13.2.

@armanbilge armanbilge merged commit 04fc57a into http4s:series/0.23 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
dependencies Dependency updates series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scala-steward @danicheg @armanbilge