Throttle Server middleware: use recursion #6267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6ffad to
f23c0ed
Compare
The `takeToken` method uses the Ref.access method, which yields a setter that yields true if it can set the value, or false if it cannot, maybe because of a concurrent write. In the latter case, the method has to re-try by using a recursive call to `takeToken`. Currently, that recursion goes through emitting an Option and flatMapping. This commit changes that to a direct call.
2dcab45 to
c9ec045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
takeTokenmethod uses the Ref.access method, which yields a setter. The setter yieldstrueif it can set the value, orfalseif it could not, perhaps because of a concurrent write. In the latter case, the method has to re-try.Currently, that recursion goes through emitting an Option and
flatMap. This commit changes that to a direct recursive call.