Use CE Random.javaSecuritySecureRandom instead of Java SecureRandom
#6252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
approved these changes
Apr 6, 2022
| CachedRandom.nextBytes(bytes) | ||
| encodeHexString(bytes) | ||
| } | ||
| private[middleware] def genTokenString: SyncIO[String] = |
There was a problem hiding this comment.
I wonder, can we move to F[_]: Sync instead of SyncIO? It seems genTokenString is used only when Sync is in-game.
There was a problem hiding this comment.
Ah, yes I think so :) let's do that 👍
|
The JS builds are getting flaky because of the artifact size test I added :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java
SecureRandomblocks. The JSSecureRandomwas first shimmed in http4s-crypto, then in CE.CE's
Random.javaSecuritySecureRandomdoesn't solve the blocking problem yet, but hopefully it will soon. In any case, this change lets us iterate in CE and reap the benefits everywhere.