Skip to content

Server Metrics Middleware #6246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2022
Merged

Server Metrics Middleware #6246

merged 1 commit into from
Jun 4, 2022

Conversation

diesalbla
Copy link
Contributor

  • Extract local methods for main operations: starting the metric "timer", ending the metrics "timer".
  • Rename MetricsRequestContext to MetricsEntry, because they are not directly related to requests, and "context" is also used with "ContextRequest" and "ContextResponse", which can add confusion.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:server labels Apr 5, 2022
@diesalbla diesalbla force-pushed the server_metrics_local_methods branch 5 times, most recently from 3a5d078 to fc10388 Compare April 5, 2022 10:06
@diesalbla diesalbla changed the title Server Metrics Middleware: rewrites Server Metrics Middleware Apr 5, 2022
@rossabaker
Copy link
Member

This has MiMa issues.

@diesalbla diesalbla force-pushed the server_metrics_local_methods branch from fc10388 to bacbcd5 Compare April 5, 2022 21:11
@diesalbla
Server Metrics Middleware:
d4f0a00 
Extract local methods for main operations of starting the metric "timer",
ending the metrics "timer",

Rename `MetricsRequestContext` to `MetricsContext`, because they are
not directly related to requests, and "context" is also used with
"ContextRequest" and "ContextResponse", which can add confusion.
@diesalbla diesalbla force-pushed the server_metrics_local_methods branch from bacbcd5 to d4f0a00 Compare April 5, 2022 22:17
@diesalbla
Copy link
Contributor Author

This has MiMa issues.

Fixed.

@rossabaker rossabaker added the behind-the-scenes Appreciated, but not user-facing label Jun 4, 2022
@rossabaker rossabaker merged commit b73bf1b into http4s:series/0.23 Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

Assignees
No one assigned
Labels
behind-the-scenes Appreciated, but not user-facing module:server series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diesalbla @rossabaker