Integrate Random into DigestAuth #6177
Conversation
| @deprecated( | ||
| "Uses a side-effecting NonceKeeper. Use challenge(String, AuthStore, Blocker, Duration, Int, Int).", | ||
| "0.22.13", | ||
| ) | ||
| def challenge[F[_], A]( |
There was a problem hiding this comment.
I'm not sure whether this signature is still valid, but I thought NonceKeeper was considered dirty.
There was a problem hiding this comment.
It's impossible to be called publicly, since NonceKeeper is package private -- I had a @deprecated on it but it must have gotten lost. Thanks for putting it back
| @@ -42,14 +43,15 @@ private[authentication] object NonceKeeperF { | |||
| currentMillis <- Clock[F].monotonic(MILLISECONDS) | |||
| lastCleanupMillis <- Ref[F].of(currentMillis) | |||
| nonces = new LinkedHashMap[String, NonceF[F]] | |||
| random <- Random.javaSecuritySecureRandom[F](blocker) | |||
There was a problem hiding this comment.
This is as high up as we can pull Random without making it public API. In Cats-Effect 3, we can consider surfacing it all the way to the top.
server/src/main/scala/org/http4s/server/middleware/authentication/Nonce.scala
Outdated
Show resolved
Hide resolved
…ion/Nonce.scala Co-authored-by: Daniel Esik <e.danicheg@yandex.ru>
|
I'll hold just to confirm that new deprecation was desired. |
| @deprecated( | ||
| "Uses a side-effecting NonceKeeper. Use challenge(String, AuthStore, Blocker, Duration, Int, Int).", | ||
| "0.22.13", | ||
| ) | ||
| def challenge[F[_], A]( |
There was a problem hiding this comment.
It's impossible to be called publicly, since NonceKeeper is package private -- I had a @deprecated on it but it must have gotten lost. Thanks for putting it back
|
👍 Okay, yeah, I thought that was maybe the signature that motivated this whole thing. |
Integrates
RandomintoDigestAuthto avoid blocking.