Skip to content

Add ability to override container resources #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2023
Merged

Add ability to override container resources #198

merged 2 commits into from
Feb 1, 2023

Conversation

ymktmk
Copy link
Contributor

@ymktmk ymktmk commented Jan 31, 2023

I had a use case where I wanted to override container-resources such as cpu and memory.
I would like to add the ability to optionally override container-resources.

@ymktmk ymktmk requested a review from h3poteto as a code owner January 31, 2023 17:09
h3poteto
h3poteto approved these changes Feb 1, 2023
View reviewed changes
Copy link
Owner

@h3poteto h3poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@h3poteto h3poteto merged commit 701e1c9 into h3poteto:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3poteto h3poteto h3poteto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ymktmk @h3poteto