Skip to content

fix mruby code lineno #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2017
Merged

fix mruby code lineno #1239

merged 1 commit into from
Apr 4, 2017

Conversation

i110
Copy link
Contributor

@i110 i110 commented Mar 29, 2017 •
edited
Loading

I think there are 3 problems:

  1. lineno parsed in compilation phase is not passed to mruby handler (this causes lineno mismatch when mruby exception is raised)
  2. yaml's lineno is 0-origin, but we want 1-origin lineno
  3. problems with Block Scalar Style (see: adjust line number when scalar block style is used yoml#6)

@kazuho
Copy link
Member

kazuho commented Mar 29, 2017

Thank you for the fix!

Would you mind adding a test that covers this issue?

@kazuho kazuho added this to the v2.2 milestone Mar 29, 2017
@kazuho kazuho merged commit 895e058 into master Apr 4, 2017
@kazuho kazuho mentioned this pull request Apr 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@i110 @kazuho