Stop reading from the socket after sending a '400 Bad request' #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending a '400 Bad request', stop reading from the socket. Not doing so risks having `handle_incoming_request` being called a second time, and assert because a write is already scheduled: ``` do_write h2o/lib/common/socket/evloop.c.h:257:5 h2o_socket_write h2o/lib/common/socket.c:576:9 send_bad_request h2o/lib/http1.c:413:5 handle_incoming_request h2o/lib/http1.c:490:13 reqread_on_read h2o/lib/http1.c:506:9 read_on_ready h2o/lib/common/socket/evloop.c.h:235:5 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a '400 Bad request', stop reading from the socket. Not
doing so risks having
handle_incoming_requestbeing called a secondtime, and assert because a write is already scheduled: