google/oss-fuzz integration #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbergstroem
reviewed
Jan 31, 2017
| @@ -567,4 +579,7 @@ ELSE () | |||
| SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -pthread") | |||
| ENDIF () | |||
|
|
|||
| SET(CMAKE_CXX_FLAGS "${CMAKE_C_FLAGS}") | |||
| # Retain CXX_FLAGS for std c++ compatiability across fuzz build/test environments | |||
There was a problem hiding this comment.
*compatibility
(thanks for the great PR; this is all feedback I could find)
There was a problem hiding this comment.
Oops -- fixed this typo.
Thanks for the positive feedback!
|
Thank you for the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR enables the h2o fuzzer to run in the google/oss-fuzz (continuous testing) environment. Here is a summary of the changes:
OSS_FUZZcmake flag to support interoperability with oss-fuzz's LibFuzzingEngineNote that as of this writing a bug exists in the fuzzing driver that causes inputs that trigger reproxying to make abberrant network requests. That bug fix will be handled in a separate PR.
Once these two PRs are vetted/merged I can remove the workarounds from the oss-fuzz/h2o integration staging branch, work out any final kinks and submit a PR to google.
Jon