Skip to content

adjust line number when scalar block style is used #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2017
Merged

adjust line number when scalar block style is used #6

merged 1 commit into from
Mar 29, 2017

Conversation

i110
Copy link
Contributor

@i110 i110 commented Mar 29, 2017 •
edited
Loading

when Block Scalar Style is used, yaml_event_t's start_mark.line indicates the block indicator (i.e. | or >), but the content always starts from the next line of it.

This causes lineno mismatches in cases like the following:

hosts:
  "*":
    paths:
      "/":
        mruby-handler: |
          proc {|env|
            raise "HOGE" # <- line 7
          }

but error message says lineno is 6. From yoml users, currently there're no ways to know the scalar style and how to adjust it

@i110 i110 mentioned this pull request Mar 29, 2017
Merged
@kazuho kazuho merged commit 6db7ab9 into master Mar 29, 2017
@kazuho
Copy link
Member

kazuho commented Mar 29, 2017

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i110 @kazuho