Skip to content

Conversation

wshoy
Copy link
Contributor

@wshoy wshoy commented Jun 20, 2024

Ability to easily distinguish between files and directories is essential.
It looks just like in #2186:

@harshad1
Copy link
Collaborator

Looks nice imo

@harshad1
Copy link
Collaborator

We tint icons gold to show that they are favorites. Does this interfere with that?

@gsantner
Copy link
Owner

gsantner commented Jun 21, 2024 via email

@wshoy
Copy link
Contributor Author

wshoy commented Jun 21, 2024

We tint icons gold to show that they are favorites. Does this interfere with that?

It does not. I have modified only the existing code. It works just like it did before.

@wshoy
Copy link
Contributor Author

wshoy commented Jun 21, 2024

At same time people (including me) want to keep it simple and non-distracting.

I think it's still simple as there are only two things: files and folders. Above all, making the file browser easier to navigate (even when using "folder first") is more important than aesthetics (though I think it looks better).

To me the blue looks quite alien to all other colors in the project.

The colors are subject to change. The design is taken from #2186.

@harshad1
Copy link
Collaborator

Perhaps we can make the file icon more different instead?

Something like this:

image

An outline file icon makes it distinct from the folder icon without looking visually jarring

(From: https://dribbble.com/shots/4404297-Material-Icons-File-And-folder, don't know if this has an appropriate license)

@wshoy
Copy link
Contributor Author

wshoy commented Jun 26, 2024

Perhaps we can make the file icon more different instead?

After looking at other file browsers, for me there are two options:

  1. Use color (blue) and keep the icons.
  2. Change the icon(s), make folders dark grey and files light grey. Changing only the icons is not enough if they look basically the same in peripheral vision.

I find the lack of color contrast very unusual. Even most minimal file managers have either colored folders or light files with dark folders.

@harshad1
Copy link
Collaborator

light files with dark folders.

This is effectively what I am proposing. Switching to an outline only icon will make them more distinct without changing the appearance otherwise.

@wshoy
Copy link
Contributor Author

wshoy commented Jun 27, 2024

Switching to an outline only icon

I've modified the file SVG and it's like night and day when compared to what we have right now.

image

@gsantner
Copy link
Owner

gsantner commented Jun 27, 2024 via email

@gsantner
Copy link
Owner

Need to compile and check it out but looks good code wise.

@gsantner gsantner changed the title Add unique colors for file/folder icons, make folders blue - #2186 File browser: Make Folder and file icons visually better distinct (outlined icon for file), fixes #2186 Jul 16, 2024
@gsantner gsantner merged commit 0508b4b into gsantner:master Jul 16, 2024
@gsantner
Copy link
Owner

Thank you, merged

@gsantner gsantner added this to the Markor v2.13 milestone Jul 16, 2024
elyahw referenced this pull request in stelijahsoftware/marelias-notepad Sep 26, 2024
…tlined icon for file), (PR by @wshoy #2331 fixes #2186)

(cherry picked from commit 0508b4b)
@wshoy wshoy deleted the folderColor branch October 3, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File browser: Make Folder and file icons visually better distinct (e.g. using color)
3 participants