-
Notifications
You must be signed in to change notification settings - Fork 408
File browser: Make Folder and file icons visually better distinct (outlined icon for file), fixes #2186 #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks nice imo |
We tint icons gold to show that they are favorites. Does this interfere with that? |
Thank you!
Humbly said, I know some people want a bit more differentiation. At same time people (including me) want to keep it simple and non-distracting. To me
the blue looks quite alien to all other colors in the project.
|
It does not. I have modified only the existing code. It works just like it did before. |
I think it's still simple as there are only two things: files and folders. Above all, making the file browser easier to navigate (even when using "folder first") is more important than aesthetics (though I think it looks better).
The colors are subject to change. The design is taken from #2186. |
Perhaps we can make the file icon more different instead? Something like this: An outline file icon makes it distinct from the folder icon without looking visually jarring (From: https://dribbble.com/shots/4404297-Material-Icons-File-And-folder, don't know if this has an appropriate license) |
After looking at other file browsers, for me there are two options:
I find the lack of color contrast very unusual. Even most minimal file managers have either colored folders or light files with dark folders. |
This is effectively what I am proposing. Switching to an outline only icon will make them more distinct without changing the appearance otherwise. |
Thanks for attaching the screenshot too. It looks very good to me too, while also not distracting.
|
Need to compile and check it out but looks good code wise. |
Thank you, merged |
Ability to easily distinguish between files and directories is essential.

It looks just like in #2186: