Add support for GH enterprise #105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @naxhh , Thanks a lot for your contribution! As far as testing goes, it would be great if you could include tests that cover the new functionality you're adding. That said, we intentionally mock out the GitHub client for the purposes of making testing easier and to avoid network dependencies. So, perhaps it might make sense to update or extend the mocks. I'm at a bit of a loss for how to test this manually, however, since I don't have access to a GitHub Enterprise subscription 😄 As far as docs go, if you could be sure to update the README to include information about using git-xargs with GitHub Enterprise, that would be much appreciated! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Github Enterprise usage.
I needed something like this and I saw that the project had an issue to make this happen.
So I wanted to propose a quick Pr and get feedback on what you expect from the PR
Some questions
Relates #5
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added support for github enterprise
Migration Guide