Skip to content

--skip-archived-repos does not filter all archived repos #158

@schmidlidev

Description

@schmidlidev

Describe the bug
A clear and concise description of what the bug is.

--skip-archived-repos only skips some but not all archived repos.

To Reproduce
Steps to reproduce the behavior:

./git-xargs --dry-run --skip-archived-repos --branch-name=foo --github-org=gruntwork-io touch hello.txt

Observe output

All repos that were filtered out with the --skip-archived-repos flag

┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
| Repo name                                 | Repo URL                                                                  |
| intro-to-terraform                        | https://github.com/gruntwork-io/intro-to-terraform                        |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-aws-couchbase                   | https://github.com/gruntwork-io/terraform-aws-couchbase                   |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-gke                      | https://github.com/gruntwork-io/terraform-google-gke                      |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-kubernetes-helm                 | https://github.com/gruntwork-io/terraform-kubernetes-helm                 |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-sql                      | https://github.com/gruntwork-io/terraform-google-sql                      |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-static-assets            | https://github.com/gruntwork-io/terraform-google-static-assets            |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-load-balancer            | https://github.com/gruntwork-io/terraform-google-load-balancer            |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-ci                       | https://github.com/gruntwork-io/terraform-google-ci                       |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-status-update                   | https://github.com/gruntwork-io/pipelines-status-update                   |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-preflight-action                | https://github.com/gruntwork-io/pipelines-preflight-action                |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-aws-execute                     | https://github.com/gruntwork-io/pipelines-aws-execute                     |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-baseline-account-action         | https://github.com/gruntwork-io/pipelines-baseline-account-action         |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-provision-access-control-action | https://github.com/gruntwork-io/pipelines-provision-access-control-action |
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

This is 13 repos, however gruntwork-io actually has 18 archived repos at this time. For example, terraform-google-network is an archived repo which is not present in this list, and is present in the other output sections for repos which will be processed.

The exact repos which are or are not filtered may depend on where exactly they show up in the paginated API results, so these results might not be exactly reproducible, but any org with a sufficient concentration of archived repos should be able to demonstrate this issue.

Expected behavior
A clear and concise description of what you expected to happen.

All archived reps should be filtered out.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

I have opened a PR to fix this issue. #157

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions