Skip to content

include --version in helm upgrade #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

include --version in helm upgrade #1532

merged 1 commit into from
Apr 1, 2025

Conversation

jijiechen
Copy link
Contributor

Description

fixes #1531

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs: N/A
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Make a plan for release of the functionality in this PR. If it delivers value to an end user, you are responsible for ensuring it is released promptly, and correctly. If you are not a maintainer, you are responsible for finding a maintainer to do this for you.

Release Notes (draft)

Updated helm.Upgrade to honor the version options.

Migration Guide

@jijiechen
include --version in helm upgrade
d8a3256 
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
james03160927
james03160927 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit a482236 into gruntwork-io:main Apr 1, 2025
2 checks passed
@jijiechen jijiechen mentioned this pull request May 12, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james03160927 james03160927 james03160927 approved these changes

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

@lev-ok lev-ok Awaiting requested review from lev-ok

@yhakbar yhakbar Awaiting requested review from yhakbar yhakbar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include --version in helm upgrade
2 participants
@jijiechen @james03160927