Skip to content

chore: Adding Terragrunt team to CODEOWNERS #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2025
Merged

chore: Adding Terragrunt team to CODEOWNERS #1513

merged 3 commits into from
Feb 21, 2025

Conversation

yhakbar
Copy link
Contributor

@yhakbar yhakbar commented Feb 14, 2025

Description

Denis shouldn't be responsible for taking care of this repo by himself.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Make a plan for release of the functionality in this PR. If it delivers value to an end user, you are responsible for ensuring it is released promptly, and correctly. If you are not a maintainer, you are responsible for finding a maintainer to do this for you.

Release Notes (draft)

Updated CODEOWNERS.

@yhakbar yhakbar requested a review from denis256 as a code owner February 14, 2025 00:10
james03160927
james03160927 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927
Copy link
Contributor

Hi @yhakbar, it seems like you need to update the branch before you merge.

@james03160927
Copy link
Contributor

Seems to be out-of-date

image

@yhakbar yhakbar merged commit 2aade3d into main Feb 21, 2025
1 of 3 checks passed
@yhakbar yhakbar deleted the chore/adding-terragrunt-team-to-codeowners branch February 21, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james03160927 james03160927 james03160927 approved these changes

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhakbar @james03160927