Skip to content

use the new sdk for azure resource group #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

use the new sdk for azure resource group #1511

merged 3 commits into from
Feb 18, 2025

Conversation

james03160927
Copy link
Contributor

Description

Fixes #1501.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Make a plan for release of the functionality in this PR. If it delivers value to an end user, you are responsible for ensuring it is released promptly, and correctly. If you are not a maintainer, you are responsible for finding a maintainer to do this for you.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james03160927 james03160927 force-pushed the new-azure-resource-group branch from 869082f to 59779d7 Compare February 8, 2025 00:37
@james03160927 james03160927 self-assigned this Feb 8, 2025
@denis256
Copy link
Member 

[INFO] Initializing environment for https://github.com/gruntwork-io/pre-commit.
goimports................................................................Failed
- hook id: goimports
- files were modified by this hook

modules/azure/client_factory.go
modules/azure/client_factory.go

@james03160927
Copy link
Contributor Author

Hi @denis256, PTAL. This should be good for another review. Failure test doesn't seem to be relevant to this PR.

denis256
denis256 reviewed Feb 17, 2025
View reviewed changes
modules/azure/client_factory.go
@@ -962,6 +963,14 @@ func CreateManagedEnvironmentsClientE(subscriptionID string) (*armappcontainers.
return client, nil
}

func CreateResourceGroupClientV2E(subscriptionID string) (*armresources.ResourceGroupsClient, error) {
clientFactory, err := getArmResourcesClientFactory(subscriptionID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be checked for empty subscriptionID?

@james03160927 james03160927 merged commit 15f245c into main Feb 18, 2025
2 of 3 checks passed
@james03160927 james03160927 deleted the new-azure-resource-group branch February 18, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 approved these changes

Assignees

@james03160927 james03160927

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terratest azure assert fail due to token expiration
2 participants
@james03160927 @denis256