Skip to content

Get and Put for ECR repo policies #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2025
Merged

Get and Put for ECR repo policies #1519

merged 3 commits into from
Mar 13, 2025

Conversation

felixfriedrich
Copy link
Contributor

@felixfriedrich felixfriedrich commented Mar 9, 2025 •
edited
Loading

Description

#1520

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Make a plan for release of the functionality in this PR. If it delivers value to an end user, you are responsible for ensuring it is released promptly, and correctly. If you are not a maintainer, you are responsible for finding a maintainer to do this for you.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james03160927
Copy link
Contributor

Hi @felixfriedrich, is this change in the draft mode? Not ready for review?

@felixfriedrich
Copy link
Contributor Author

Hi @felixfriedrich, is this change in the draft mode? Not ready for review?

I was reading through the Gruntwork contribution guidelines, I think an issue is missing. Not sure what else.

@felixfriedrich
Copy link
Contributor Author

I created an issue: #1520

The goimports pre-commit check fails, however this PR doesn't touch any imports. According to the guide the release notes are for a release, or shall I write some for this specific change, too? If so, where can I place them?

@felixfriedrich felixfriedrich marked this pull request as ready for review March 12, 2025 08:54
james03160927
james03160927 approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit 3ba689f into gruntwork-io:main Mar 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james03160927 james03160927 james03160927 approved these changes

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

@lev-ok lev-ok Awaiting requested review from lev-ok

@yhakbar yhakbar Awaiting requested review from yhakbar yhakbar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfriedrich @james03160927