Enable proxy setting #560
Merged
Enable proxy setting #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6eab24d to
a3e9bf9
Compare
0cd38da to
20ea4c6
Compare
fb46d77 to
c31c413
Compare
brikis98
reviewed
Jun 22, 2020
modules/http-helper/http_helper.go
Outdated
| @@ -31,9 +31,18 @@ func HttpGet(t testing.TestingT, url string, tlsConfig *tls.Config) (int, string | |||
| func HttpGetE(t testing.TestingT, url string, tlsConfig *tls.Config) (int, string, error) { | |||
| logger.Logf(t, "Making an HTTP GET call to URL %s", url) | |||
|
|
|||
| // Get a deepcopy of the default Transport implementation | |||
| DefaultTransporter := http.DefaultTransport.(*http.Transport).Clone() | |||
There was a problem hiding this comment.
If Clone does a deep copy, couldn't this be simplified to:
tr := http.DefaultTransport.(*http.Transport).Clone()That would make the code more maintainable too in case http.Transport adds new fields in the future.
There was a problem hiding this comment.
Thank you for pointing that out.
b29a604 to
815ac0d
Compare
815ac0d to
bd9079b
Compare
brikis98
approved these changes
Jun 23, 2020
|
Tests passed! Merging now. |
This was referenced Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of task to be completed?
HTTP_PROXY,HTTPS_PROXY,NO_PROXY