Prepare for the new batch call API. #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yang-g - please don't merge until everyone mentioned has taken a look at this. |
|
LGTM |
| @@ -70,7 +70,7 @@ static void pygrpc_call_dealloc(Call *self) { | |||
| self->ob_type->tp_free((PyObject *)self); | |||
| } | |||
|
|
|||
| static const PyObject *pygrpc_call_invoke(Call *self, PyObject *args) { | |||
| static const PyObject *pygrpc_call_invoke_old(Call *self, PyObject *args) { | |||
There was a problem hiding this comment.
Is this method rename intended?
|
Perhaps this usually goes without saying but: you intend to squash these commits, right? LGTM in that case. |
Rename all core API functions that are on their way to deprecation with an _old tag across all wrappings.
yang-g
added a commit
that referenced
this pull request
Feb 3, 2015
Prepare for the new batch call API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename all core API functions that are on their way to deprecation with an _old tag across all wrappings.
@murgatroid99 @tbetbetbe @nathanielmanistaatgoogle - please check my wrapping changes (they were made in bulk)