Skip to content

Update boringssl #23012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2020
Merged

Update boringssl #23012

merged 2 commits into from
May 21, 2020

Conversation

srini100
Copy link
Contributor

Update boringssl

@srini100 srini100 requested review from muxi and jtattermusch May 20, 2020 22:02
@srini100 srini100 added the release notes: no Indicates if PR should not be in release notes label May 20, 2020
@stanley-cheung stanley-cheung mentioned this pull request May 20, 2020
Merged
@muxi muxi requested a review from stanley-cheung May 20, 2020 23:32
@srini100 srini100 merged commit 02f0998 into grpc:master May 21, 2020
@jtattermusch
Copy link
Contributor

Thanks for doing this!

Contents of the PR are looking good, but two small nits:

  • I usually put generated code changes in separate commit to make it clear which changes have been made by hand and which are autogenerated (it makes it easier to review things)
  • I usually go even further and put each step from the boringssl update instructions to a separate commit because it makes the commit history pretty self-explanatory and it can almost double as instructions for upgrading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@gnossen gnossen Awaiting requested review from gnossen

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

@veblush veblush Awaiting requested review from veblush

@stanley-cheung stanley-cheung Awaiting requested review from stanley-cheung

1 more reviewer

@muxi muxi muxi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srini100 @jtattermusch @muxi