Skip to content

Support client side handshaker handoff fd #21352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2019
Merged

Support client side handshaker handoff fd #21352

merged 1 commit into from
Dec 3, 2019

Conversation

yang-g
Copy link
Contributor

@yang-g yang-g commented Dec 3, 2019

This is similar to what we do on the server side in chttp2_server.cc's handshake done code. It is just we never needed to support handoff on the client side.

@yang-g yang-g requested a review from yashykt December 3, 2019 19:02
@yang-g yang-g added the release notes: no Indicates if PR should not be in release notes label Dec 3, 2019
@yang-g
Copy link
Contributor Author

yang-g commented Dec 3, 2019

CLA bot seems stuck. Closing and reopening.

@yang-g yang-g closed this Dec 3, 2019
@yang-g yang-g reopened this Dec 3, 2019
@yang-g
Copy link
Contributor Author

yang-g commented Dec 3, 2019

Test failures:
ios: #20751
Bazel Opt: #20928
Bazel Tsan: #19726
Bazel Windows Debug: #20922
Interop: #20890

@yang-g yang-g merged commit 2907466 into grpc:master Dec 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yashykt yashykt yashykt approved these changes

Assignees

@yashykt yashykt

Labels
area/core lang/core release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yang-g @yashykt