Skip to content

C# Fix Unobserved Task Exception problem for cancelled calls with unexhausted response stream. #21202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2019
Merged

C# Fix Unobserved Task Exception problem for cancelled calls with unexhausted response stream. #21202

merged 4 commits into from
Dec 3, 2019

Conversation

jtattermusch
Copy link
Contributor

Fixes #17458.

A more detailed analysis of what happens is here: #17458 (comment)

@jtattermusch jtattermusch added lang/C# release notes: yes Indicates if PR needs to be in release notes labels Nov 14, 2019
@jtattermusch
Copy link
Contributor Author

CC @jskeet

jskeet
jskeet reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

apolcyn
apolcyn reviewed Nov 15, 2019
View reviewed changes
@jtattermusch
Copy link
Contributor Author

@apolcyn PTAL.

@jtattermusch jtattermusch merged commit f7e34e9 into grpc:master Dec 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apolcyn apolcyn apolcyn approved these changes

+1 more reviewer

@jskeet jskeet jskeet left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@apolcyn apolcyn

Labels
lang/C# release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unobserved task exception for disposed but not exhausted-by-client server streaming call
3 participants
@jtattermusch @jskeet @apolcyn