Skip to content

Conversation

lidizheng
Copy link
Contributor

  • Adds two formatting scripts
  • Print reference to the script if check failed
  • The script supports macOS and Linux

CC @jtattermusch

Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! It looks like you spent a lot of time thinking about portability.

Just a couple of nits.

function download_buildifier() {
platform="$(uname -s)"
case "${platform}" in
Linux*) download_link="https://github.com/bazelbuild/buildtools/releases/download/${BUILDIFIER_VERSION}/buildifier";;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice portability!

@lidizheng lidizheng merged commit 5cbec48 into grpc:master Nov 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants