Skip to content

xds testing: set fault injection env var, so the test can be turned on #25735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

xds testing: set fault injection env var, so the test can be turned on #25735

merged 1 commit into from
Mar 17, 2021

Conversation

menghanl
Copy link
Contributor

This reverts #25676

Note that this doesn't turn on the tests. The tests needs to be turned on in the kokoro shell scripts.

@menghanl
xds testing: set fault injection var, so tests can be turned on in ot…
105e030 
…her repos

Note that this doesn't turn on the tests. The tests needs to be turned on in the kokoro shell scripts.
@menghanl
Copy link
Contributor Author

cc @donnadionne

@menghanl menghanl added the release notes: no Indicates if PR should not be in release notes label Mar 16, 2021
lidizheng
lidizheng approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@lidizheng lidizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually confirmed that on HEAD with #25694 the interop test passes with and without --xds_v3_support flag.

@menghanl menghanl merged commit 74b767d into grpc:master Mar 17, 2021
@menghanl menghanl deleted the turn_on_fault_injection_tests branch March 17, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfawley dfawley dfawley approved these changes

+2 more reviewers

@voidzcy voidzcy voidzcy approved these changes

@lidizheng lidizheng lidizheng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@menghanl @voidzcy @lidizheng @dfawley