Skip to content

Use crosscompilation to build python armv7 wheels #25704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 17, 2021
Merged

Use crosscompilation to build python armv7 wheels #25704

merged 6 commits into from
Mar 17, 2021

Conversation

jtattermusch
Copy link
Contributor

@jtattermusch jtattermusch commented Mar 12, 2021 •
edited
Loading

Instead of building under an emulator (which takes 7 hours).

@jtattermusch jtattermusch force-pushed the python_crosscompile_arm32_wheels branch from 750c67d to 959efdb Compare March 16, 2021 11:47
@jtattermusch jtattermusch added release notes: yes Indicates if PR needs to be in release notes lang/Python labels Mar 16, 2021
@jtattermusch jtattermusch changed the title DO NOT MERGE: Python crosscompile arm32 wheels Use crosscompilation to build python armv7 wheels Mar 16, 2021
@jtattermusch jtattermusch requested review from gnossen and drfloob March 16, 2021 16:17
@jtattermusch jtattermusch marked this pull request as ready for review March 16, 2021 16:17
@jtattermusch
Copy link
Contributor Author

@gnossen @drfloob this is now ready for review. As far as I can tell the wheels work (and they pass the manylinux2014 auditwheel check).

drfloob
drfloob reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@drfloob drfloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, looks like you've found a way to cut down the build time significantly. A few small comments, otherwise looks good to me.

@jtattermusch
Copy link
Contributor Author

As a followup after this PR is merged, I think we should:

  • move the arm7 artifact build from "linux_extra" to "linux" (as they are now taking a reasonable amount of time and the only reason why we had the "linux_extra" job was that it was extremely slow).
  • get rid of the (now empty) linux_extra job.
  • adjust the grpc release doc accordingly (it's going to be simpler once linux_extra is not required).

@drfloob drfloob mentioned this pull request Mar 17, 2021
Merged
gnossen
gnossen approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing that really needed much scrutiny from my perspective was the pyconfig.h copy. While I think there are other ways to achieve the same effect, it probably doesn't matter since this is all happening within a docker container.

Thanks for making this happen!

@jtattermusch jtattermusch merged commit 0088dae into grpc:master Mar 17, 2021
@fedej fedej mentioned this pull request Jun 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drfloob drfloob drfloob approved these changes

@gnossen gnossen gnossen approved these changes

@apolcyn apolcyn Awaiting requested review from apolcyn

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees

@gnossen gnossen

Labels
lang/Python release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtattermusch @drfloob @gnossen