Skip to content

Added CMakeLists.txt to cpp/examples #25692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2021
Merged

Added CMakeLists.txt to cpp/examples #25692

merged 1 commit into from
Mar 18, 2021

Conversation

veblush
Copy link
Contributor

@veblush veblush commented Mar 11, 2021 •
edited
Loading

Added the missing CMakeLists.txt to cpp/examples so that cmake can build all gRPC C++ examples. Once this is merged, we can remove makefiles and update the tutorial doc to use cmake instead of makefile.

@veblush veblush added release notes: no Indicates if PR should not be in release notes lang/c++ area/build labels Mar 11, 2021
@veblush veblush requested a review from jtattermusch March 11, 2021 19:55
@veblush veblush marked this pull request as ready for review March 11, 2021 19:55
jtattermusch
jtattermusch approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veblush veblush merged commit 343eb56 into grpc:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/build lang/c++ release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veblush @jtattermusch