Fix 3.9 MacOS from-source build #24998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysconfig.get_config_var('MACOSX_DEPLOYMENT_TARGET')
returns <str> '11.1' in Python 2.7 and <int> 11 in Python 3.9 causing exception: builtins.TypeError: expected string or bytes-like object
|
|
|
My work around is to use: so the OS identifies as version 10.16, see the command |
ReSqAr
reviewed
Jan 6, 2021
Avoid attempting to ever parse a potential None value on the above environment var, then carry on with Mac OS X specific version checking logic...
gnossen
approved these changes
Jan 12, 2021
|
Adding @lidizheng for a second review. |
lidizheng
approved these changes
Jan 12, 2021
|
When will this get released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysconfig.get_config_var('MACOSX_DEPLOYMENT_TARGET')
returns '11.1' in Python 2.7 and 11 in Python 3.9 causing exception: builtins.TypeError: expected string or bytes-like object
@nicolasnoble
Fixes #25082