Skip to content

Fix subject_alternative_names deletion #24950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

Fix subject_alternative_names deletion #24950

merged 1 commit into from
Dec 10, 2020

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Dec 9, 2020

No description provided.

@yashykt yashykt added the release notes: no Indicates if PR should not be in release notes label Dec 9, 2020
@yashykt yashykt requested a review from ZhenLian December 9, 2020 20:25
drfloob
drfloob approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@drfloob drfloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@yashykt yashykt merged commit 1d2cce2 into grpc:master Dec 10, 2020
@yashykt yashykt deleted the delarrayfix branch May 18, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drfloob drfloob drfloob approved these changes

+1 more reviewer

@ZhenLian ZhenLian ZhenLian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashykt @drfloob @ZhenLian