cmake: choose the right protoc executable with gRPC_PROTOBUF_PROVIDER=package #12411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @kskalski @hesmar this should solve the issues pointed out in your PRs and I feel this way is more readable. Sorry for the delay, it took me a while to come up with this PR as it was originally part of a larger effort to improve our CMakeFile.txt and add some tests to continue it keeps working well. The first prerequisite is to finish up #12305 and get it merged (and I have some followup changes on top of it). |
|
4dbfe12 to
f5624b9
Compare
|
|
f5624b9 to
9d1d052
Compare
|
|
This was referenced Sep 11, 2017
|
Will v1.6.1 contain this changes? |
|
@BusyJay most likely not, it's going to be in v1.7.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools/cmaketocmakedirectoryFixes #12230
Supersedes PRs #11891 and #11794.