Skip to content

Cherry pick fix bazel 0.20 #17446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2018
Merged

Cherry pick fix bazel 0.20 #17446

merged 2 commits into from
Dec 14, 2018

Conversation

moriarty
Copy link

@moriarty moriarty commented Dec 7, 2018

Bazel 0.20 fixes into release 1.17.1

This closes #17445

@moriarty
Copy link
Author

@grpc-google-owners any chance to get the bazel-0.20 fixes from @nicolasnoble into a versioned release of gRPC?

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@srini100 srini100 added release notes: yes Indicates if PR needs to be in release notes lang/core labels Dec 14, 2018
@grpc-testing
Copy link 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@nicolasnoble nicolasnoble merged commit c7cc34e into grpc:v1.17.x Dec 14, 2018
@grpc-testing
Copy link 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,503      Total (=)      2,020,503

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,634      Total (>)     11,175,628

 No significant differences in binary sizes

@lock lock bot locked as resolved and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a11r a11r Awaiting requested review from a11r

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@vjpai vjpai Awaiting requested review from vjpai

1 more reviewer

@nicolasnoble nicolasnoble nicolasnoble approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@nicolasnoble nicolasnoble

Labels
lang/core release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moriarty @grpc-testing @nicolasnoble @grpc-kokoro @srini100