Skip to content

Revert "Define the tests as grpc_cc_test to automatically test against all po…" #14337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2018
Merged

Revert "Define the tests as grpc_cc_test to automatically test against all po…" #14337

merged 1 commit into from
Feb 6, 2018

Conversation

adelez
Copy link
Contributor

@adelez adelez commented Feb 6, 2018

Reverts #14326 because it breaks import.

@adelez adelez requested a review from yashykt February 6, 2018 22:35
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

yashykt
yashykt approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@yashykt yashykt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grpc-testing
Copy link 

[trickle] No significant performance differences

@adelez adelez merged commit e17592c into master Feb 6, 2018
@grpc-testing
Copy link 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__0.opt.old: 1
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_MinSockPair__0.opt.new: 1


[microbenchmarks] No significant performance differences

@adelez adelez mentioned this pull request Feb 7, 2018
Merged
@mehrdada mehrdada deleted the revert-14326-foundry_integration branch April 13, 2018 00:13
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yashykt yashykt yashykt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adelez @grpc-testing @yashykt