Skip to content

Enable sourceSets in the stub example project #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Enable sourceSets in the stub example project #376

merged 2 commits into from
Feb 3, 2023

Conversation

nkhoshini
Copy link
Contributor

The stub example project explicitly disables sourceSets as the generated files do not pass ktlint checks. For new developers using IntelliJ this can be not very clear because the IDE does not recognize the generated files. This simple PR just disables the ktlint checks on generated directories.

…ava and Kotlin sources.

Subsequently, configure ktlint to avoid checking generated directories as a whole.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 25, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@jamesward jamesward merged commit 5a7bbdb into grpc:master Feb 3, 2023
@jamesward
Copy link
Contributor

Thanks! I'm working on some updates but wanted to give a heads up that you no longer need the sourceSet config for IntelliJ to recognize the generated sources. I think this was fixed in a newer version of the protobuf gradle plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants