Open context val in order to allow overriding #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjoernmayer I know it's a trivial change, but I can't merge it until you do the CLA thing. Is that possible? |
|
Hey @jamesward, just signed the thingy. |
lowasser
approved these changes
Sep 30, 2021
SanjayVas
added a commit
to world-federation-of-advertisers/common-jvm
that referenced
this pull request
Feb 18, 2022
This pulls in a fix for grpc/grpc-java#7953. It also includes a utility method for creating mocks of coroutine services, as the behavior changed with grpc/grpc-kotlin#287.
SanjayVas
added a commit
to world-federation-of-advertisers/common-jvm
that referenced
this pull request
Feb 18, 2022
This pulls in a fix for grpc/grpc-java#7953. It also includes a utility method for creating mocks of coroutine services, as the behavior changed with grpc/grpc-kotlin#287.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #261
val contextis marked asopenwith this PR in order to allow overriding it