Skip to content

No lite - fixes #234 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 29, 2021
Merged

No lite - fixes #234 #250

merged 15 commits into from
Apr 29, 2021

Conversation

jamesward
Copy link
Contributor

@jamesward jamesward commented Apr 19, 2021 •
edited by chalin
Loading

Fixes #234

@jamesward jamesward requested a review from bshaffer April 19, 2021 18:18
@jamesward jamesward added this to the 1.1.0 milestone Apr 19, 2021
bshaffer
bshaffer reviewed Apr 19, 2021
View reviewed changes
chalin
chalin reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inlined comments.

I don't think that this impacts the Quick starts (the base one and the one for Android), right? But I figured that I'd ask anyways.

@chalin
Copy link
Contributor

chalin commented Apr 19, 2021

Another thought: would it make sense to have a CHANGELOG.md file instead of adding comments to the README?

@bshaffer bshaffer mentioned this pull request Apr 29, 2021
Closed
chalin
chalin reviewed Apr 29, 2021
View reviewed changes
@jamesward @bshaffer
Update CHANGELOG.md
b5063b9 
Co-authored-by: Brent Shaffer <betterbrent@google.com>
@jamesward jamesward merged commit da32440 into master Apr 29, 2021
@jamesward jamesward deleted the no-lite branch April 29, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Remove grpc-protobuf dependency for stub runtime
3 participants
@jamesward @chalin @bshaffer