support proto3 optional fields #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@jamesward, is there any chance that you have time to review the PR? |
|
I'll need @lowasser to handle this since it's beyond my abilities :) |
|
@lowasser can you review the PR, please? |
|
Hey since Protobuff v3.15.0 optional is not experimental. Therefore, when can we move on to this issue? |
|
We have urgent need for optional fields, and it's been 3 months since this pr is created. Please speed up on this process. |
|
we are also blocked waiting for this PR merged. please review and approve ASAP |
lowasser
approved these changes
Mar 31, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, java proto3 compiler supports optional fields. But unfortunately, Kotlin grpc compiler fails to compile such fields. There is a small change based on the docs.
As protobuf supports the feature since version 3.13, I updated protobuf and grpc version in the gradle build script.