resolver: convert EndpointMap to use generics #8189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8189 +/- ##
==========================================
- Coverage 82.06% 81.93% -0.14%
==========================================
Files 410 410
Lines 40233 40216 -17
==========================================
- Hits 33018 32949 -69
- Misses 5854 5892 +38
- Partials 1361 1375 +14
🚀 New features to boost your workflow:
|
arjan-bal
approved these changes
Mar 24, 2025
resolver/map_test.go
Outdated
| @@ -174,7 +174,7 @@ func (s) TestAddressMap_Values(t *testing.T) { | |||
| } | |||
|
|
|||
| func (s) TestEndpointMap_Length(t *testing.T) { | |||
| em := NewEndpointMap() | |||
| em := NewEndpointMap[any]() | |||
There was a problem hiding this comment.
We can use struct{} as a more precise type parameter here, and int in the test cases below. Any reason to use any?
There was a problem hiding this comment.
Good idea. I just did the simplest change possible for the tests, but using the proper type is better.
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #8187 but for EndpointMap. In this case, I could find zero external usages of this type, since it is so new, so I thought it would be OK to just convert it in place.
RELEASE NOTES: