Skip to content

Cherry-pick #8164 #8166 to v1.71.x #8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2025
Merged

Cherry-pick #8164 #8166 to v1.71.x #8182

merged 3 commits into from
Mar 20, 2025

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Mar 19, 2025 •
edited
Loading

Original PRs: #8164 #8166

RELEASE NOTES:

  • xds: restore the behavior of reading bootstrap config before creating the first xDS client instead of package init time.
  • stats/opentelemetry: fix tracing to use TextMapPropagator and TracerProvider from TraceOptions instead of OpenTelemetry globals.

@purnesh42H purnesh42H force-pushed the cherry-pick-8164-8166 branch from ad7c2b0 to 18813d8 Compare March 19, 2025 07:35
@purnesh42H purnesh42H added this to the 1.71 Release milestone Mar 19, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (8b7d2fe) to head (5e2ff81).
Report is 1 commits behind head on v1.71.x.

Additional details and impacted files 
@@             Coverage Diff             @@
##           v1.71.x    #8182      +/-   ##
===========================================
+ Coverage    82.34%   82.39%   +0.05%     
===========================================
  Files          387      387              
  Lines        38944    38942       -2     
===========================================
+ Hits         32068    32086      +18     
+ Misses        5566     5556      -10     
+ Partials      1310     1300      -10
Files with missing lines Coverage Δ
stats/opentelemetry/client_tracing.go 76.47% <100.00%> (ø)
stats/opentelemetry/server_metrics.go 89.82% <ø> (ø)
stats/opentelemetry/server_tracing.go 100.00% <100.00%> (ø)
xds/internal/xdsclient/clientimpl.go 80.85% <100.00%> (+0.76%) ⬆️
xds/internal/xdsclient/pool.go 81.08% <100.00%> (+1.66%) ⬆️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@purnesh42H purnesh42H merged commit 208e03b into grpc:v1.71.x Mar 20, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjan-bal arjan-bal arjan-bal approved these changes

@eshitachandwani eshitachandwani Awaiting requested review from eshitachandwani

@dfawley dfawley Awaiting requested review from dfawley

Assignees

@purnesh42H purnesh42H

Labels
Type: Bug
Projects
None yet
Milestone
1.71 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@purnesh42H @arjan-bal @dfawley @eshitachandwani @vinothkumarr227