server: allow 0s grpc-timeout header values, as java is known to be able to send them #8439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8439 +/- ##
==========================================
+ Coverage 82.26% 82.34% +0.07%
==========================================
Files 414 414
Lines 40410 40418 +8
==========================================
+ Hits 33243 33281 +38
+ Misses 5796 5774 -22
+ Partials 1371 1363 -8
🚀 New features to boost your workflow:
|
arjan-bal
approved these changes
Jul 9, 2025
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Jul 9, 2025
…ble to send them (grpc#8439)
dimpavloff
pushed a commit
to dimpavloff/grpc-go
that referenced
this pull request
Aug 22, 2025
…ble to send them (grpc#8439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc/grpc-java#12201 was recently created to prevent this, but older versions will still do it. This reverts our old behavior of allowing 0 second timeouts (pre- #8290).
I would propose that we do not revert the change in http_util and allow the RPC to instantly timeout instead of throw an internal error.
cc @ejona86
RELEASE NOTES: