-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Closed
Labels
Description
It seems there may have been a change in the stdlib that makes WithTimeout
spawn a goroutine which may still be alive when we run CheckGoroutines
in this test.
--- FAIL: TestCheck (2.05s)
leakcheck_test.go:58: CheckGoroutines found 4 leaks, want 3 leaks
leakcheck_test.go:59: leaked goroutines:
<snip out expected goroutines>
Leaked goroutine: goroutine 8 [runnable]:
context.WithDeadlineCause.func2()
/opt/hostedtoolcache/go/1.24.2/x64/src/context/context.go:643
created by time.goFunc
/opt/hostedtoolcache/go/1.24.2/x64/src/time/sleep.go:215 +0x38
FAIL
FAIL google.golang.org/grpc/internal/leakcheck 12.308s
We can probably just add it to
grpc-go/internal/leakcheck/leakcheck.go
Line 172 in 4cedec4
var goroutinesToIgnore = []string{ |
We should also tidy up these error messages here while we're here:
t.Error("blah") |
t.Error("blah") |
EDIT: link to failure: https://github.com/grpc/grpc-go/actions/runs/14715401045/job/41297489567?pr=8155#step:8:116