Correctness: Make some private & internal classes sealed where possible #2559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
approved these changes
Dec 9, 2024
|
Thanks! |
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Aug 5, 2025
Closed
Closed
Closed
This was referenced Aug 15, 2025
This was referenced Aug 17, 2025
This was referenced Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should in theory also be faster, as some virtual method table lookups can be avoided.
I haven't tested if it introduces any performance regressions due to runtime black magic inner workings.
My laptop cannot produce repeatable results due to throttling & background services.
I hope you have a benchmark setup to test it.
There are some whitespace changes due to:
trim_trailing_whitespace = trueinsert_final_newline = truein
.editorconfig