Rework release workflows using Github runners (replacing Zig) #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
3e34be3 to
9e09b7a
Compare
7a24238 to
8292c7c
Compare
37e2757 to
3366823
Compare
x64 and arm64 on 3 platforms)
x64 and arm64 on 3 platforms)x64 and arm64)
baece2c to
6d05c71
Compare
x64 and arm64)There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the grpc-web release workflows by migrating from make/Zig-based build systems to Bazel across all platforms, and updates GitHub Actions to use current versions. The changes address macOS build issues while improving consistency and maintainability of the build process.
- Removes Zig build system and migrates all platforms to use Bazel for building the protoc plugin
- Standardizes version handling across workflows with dynamic computation from inputs or Git refs
- Updates GitHub Actions versions and adds support for ARM64 runners on all platforms
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/make-plugin-windows.yml | Migrated from x86_64-only to multi-arch (including ARM64) with Bazel build system |
| .github/workflows/make-plugin-mac-os.yml | Replaced make-based build with Bazel and added ARM64 support |
| .github/workflows/make-plugin-linux.yml | Migrated from Docker-based build to direct Bazel build with ARM64 support |
| .github/workflows/make-plugin-arm.yml | Removed Zig-based ARM plugin workflow (functionality moved to other workflows) |
| javascript/net/grpc/web/generator/build.zig | Removed Zig build configuration file |
| .bazelrc.windows | Added Windows-specific Bazel configuration |
| .bazelrc | Simplified main Bazel configuration with cleaner formatting |
| net/grpc/gateway/docker/protoc_plugin/Dockerfile | Added TODO comment about migrating to Bazel |
| .github/workflows/release-source-archive.yml | Updated checkout action to v3 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
978c812 to
63cfef9
Compare
This PR modernizes the grpc-web release workflows by migrating from make/Zig-based build systems to Bazel across all platforms, and updates GitHub Actions to use current versions. Removes Zig build system and migrates all platforms to use Bazel for building the protoc plugin Standardizes version handling across workflows with dynamic computation from inputs or Git refs Updates GitHub Actions versions and adds support for ARM64 runners on all platforms
63cfef9 to
ba14aec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the grpc-web release workflows by migrating from make/Zig-based build systems to Bazel across all platforms, and updates GitHub Actions to use current versions.
Main changes:
References
Github hosted runners:
https://docs.github.com/en/actions/reference/runners/github-hosted-runners
Fixes #1495
For #1466 :)